Fitting new lattice-constrained NP model, PDFs from correction files through helicities #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) | ||
| pdf_hist += "UncertByHelicity" | ||
| pdf_corr_hist += "UncertByHelicity" | ||
| symmetrize = "quadratic" |
Collaborator
There was a problem hiding this comment.
Where is this variable used?
| cols, | ||
| **info, | ||
| ) | ||
| if theory_helpers.get("pdf_from_corr") is not None: |
Collaborator
There was a problem hiding this comment.
Maybe better:
for pdf_name, pdf in theory_helpers.get("pdf_from_corr", {}).itmes():
logger.debug(
f"Make PDF (from correction file) uncertainty by helicity histograms for {dataset_name} and PDF from correction {pdf_name}"
)
add_pdfUncertByHelicity_hist(
results,
df,
pdf,
pdf_name,
pdf_name,
axes,
cols,
**info,
)
| # alphaS from correction histograms only available for these sets, | ||
| # so fall back to CT18Z for other sets | ||
| if not ("MSHT20" in asname or "CT18Z" in asname or "MSHT20an3lo" in asname): | ||
| if not ( |
Collaborator
There was a problem hiding this comment.
can we dynamically check if the correction histogram is there and otherwise use the default? E.g.
if not asname in theory_corrections.valid_theory_corrections()
| pdf_hist = pdfName | ||
| pdf_corr_hist = ( | ||
| f"scetlib_dyturbo{pdf.upper().replace('AN3LO', 'an3lo')}VarsCorr" | ||
| if self.corr_hist_name == "scetlib_dyturboCorr" |
Collaborator
There was a problem hiding this comment.
Should this not be something with "MSHT20" here?
lucalavezzo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related https://gitlab.cern.ch/cms-wmass/wremnants-data/-/merge_requests/90